Capture the property bag from metadata request and pass it to Function load request #8895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR description doesn't include any details or reference any bug for context. Please provide this info so reviewers know what you're trying to accomplish. I.e. fill out the template. |
mathewc
reviewed
Nov 7, 2022
mathewc
reviewed
Nov 7, 2022
Apologies for not adding the details early on. I just wanted to get a build going. However, I waited too long to add the details. Going to add them ASAP. |
…e-worker-protobuf. Tag: v1.6.0-protofile Commit: 186030d
soninaren
force-pushed
the
nasoni/propertyBag
branch
from
17ddd02 to
f3ac6b9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jviau
reviewed
Nov 8, 2022
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Show resolved
Hide resolved
mathewc
reviewed
Nov 9, 2022
mathewc
approved these changes
Nov 9, 2022
|
/backport to v3.x |
|
Started backporting to v3.x: https://github.com/Azure/azure-functions-host/actions/runs/3425931008 |
|
@soninaren backporting to v3.x failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Capture the property bag from metadata request and pass it to Function load request
Using index info to reconstruct a base tree...
M src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs
M test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs
M test/WebJobs.Script.Tests/Workers/Rpc/TestFunctionRpcService.cs
Falling back to patching base and 3-way merge...
Auto-merging test/WebJobs.Script.Tests/Workers/Rpc/TestFunctionRpcService.cs
CONFLICT (content): Merge conflict in test/WebJobs.Script.Tests/Workers/Rpc/TestFunctionRpcService.cs
Auto-merging test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs
CONFLICT (content): Merge conflict in test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs
Auto-merging src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Capture the property bag from metadata request and pass it to Function load request
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8302
resolves #8898
Pull request checklist
release_notes.mdAdditional information
Additional PR information
As part of work for project stein. The function host send a metadata request to the worker process to get the function metadata. That worker would index functions and send the function metadata response. This request is only sent to one worker, however there is indexing related data that needs to be shared between workers.
Proposed solution.